Feedback

restatedev · Apr 5, 2024 · 727a7d6 · 727a7d6
1 parent 2c2adb5
commit 727a7d6
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 5 deletions.
diff --git a/crates/storage-proto/proto/dev/restate/storage/v1/domain.proto b/crates/storage-proto/proto/dev/restate/storage/v1/domain.proto
@@ -218,7 +218,7 @@ message StateMutation {
 
 message InboxEntry {
     oneof entry {
-        FullInvocationId invocation = 3;
+        FullInvocationId invocation_id = 3;
         StateMutation state_mutation = 4;
     }
 }

diff --git a/crates/storage-proto/src/lib.rs b/crates/storage-proto/src/lib.rs
@@ -665,7 +665,7 @@ pub mod storage {
                 fn try_from(value: InboxEntry) -> Result<Self, Self::Error> {
                     Ok(
                         match value.entry.ok_or(ConversionError::missing_field("entry"))? {
-                            inbox_entry::Entry::Invocation(fid) => {
+                            inbox_entry::Entry::InvocationId(fid) => {
                                 restate_storage_api::inbox_table::InboxEntry::Invocation(
                                     restate_types::identifiers::FullInvocationId::try_from(fid)?,
                                 )
@@ -686,7 +686,7 @@ pub mod storage {
                 fn from(inbox_entry: restate_storage_api::inbox_table::InboxEntry) -> Self {
                     let inbox_entry = match inbox_entry {
                         restate_storage_api::inbox_table::InboxEntry::Invocation(fid) => {
-                            inbox_entry::Entry::Invocation(FullInvocationId::from(fid))
+                            inbox_entry::Entry::InvocationId(FullInvocationId::from(fid))
                         }
                         restate_storage_api::inbox_table::InboxEntry::StateMutation(
                             state_mutation,

diff --git a/crates/worker/src/partition/state_machine/command_interpreter/mod.rs b/crates/worker/src/partition/state_machine/command_interpreter/mod.rs
@@ -489,7 +489,7 @@ where
                 effects,
             ),
             _ => {
-                trace!("Received kill command for unknown invocation with id '{maybe_fid}'.");
+                trace!("Received cancel command for unknown invocation with id '{maybe_fid}'.");
                 // We still try to send the abort signal to the invoker,
                 // as it might be the case that previously the user sent an abort signal
                 // but some message was still between the invoker/PP queues.

diff --git a/crates/worker/src/partition/state_machine/effect_interpreter.rs b/crates/worker/src/partition/state_machine/effect_interpreter.rs
@@ -421,7 +421,11 @@ impl<Codec: RawEntryCodec> EffectInterpreter<Codec> {
                     let inboxed_status =
                         state_storage.get_invocation_status(&invocation_id).await?;
 
-                    let_assert!(InvocationStatus::Inboxed(inboxed_invocation) = inboxed_status);
+                    let_assert!(
+                        InvocationStatus::Inboxed(inboxed_invocation) = inboxed_status,
+                        "InvocationStatus must contain an Inboxed invocation for the id {}",
+                        invocation_id
+                    );
 
                     let (in_flight_invocation_meta, invocation_input) =
                         InFlightInvocationMetadata::from_inboxed_invocation(inboxed_invocation);