Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gRPC reflection not working with gRPC-based TS services #1262

Closed
tillrohrmann opened this issue Mar 5, 2024 · 2 comments
Closed

gRPC reflection not working with gRPC-based TS services #1262

tillrohrmann opened this issue Mar 5, 2024 · 2 comments
Assignees
@tillrohrmann

Comments

@tillrohrmann
Copy link
Contributor

A user reported that invoking gRPC-based TS services via grpcurl fails [1]. The problem seems to be that the TS SDK does not ship the correct file descriptors for google/protobuf/descriptor.proto and dev/restate/ext.proto. Since we are currently removing the gRPC specific parts from the SDK, I suggest to add a temporary band-aide that patches the respective files on the server side.

What is a bit unclear is whether other file descriptors are affected by the same problem.

The fix will only applied to the release-0.8 branch.

[1] https://discord.com/channels/1128210118216007792/1214469975163801661/1214469975163801661
@tillrohrmann tillrohrmann self-assigned this Mar 5, 2024
tillrohrmann added a commit to tillrohrmann/restate that referenced this issue Mar 5, 2024
@tillrohrmann
Patch google/protobuf/descriptor.proto and dev/restate/ext.proto
8c8b0c3 
The TS SDK seems to send incorrect file descriptors for google/protobuf/descriptor.proto
and dev/restate/ext.proto. This commit patches these files on the server as a temporary
solution until we remove the need for shipping Protobuf file descriptors.

This fixes restatedev#1262.
tillrohrmann added a commit to tillrohrmann/restate that referenced this issue Mar 5, 2024
@tillrohrmann
Patch google/protobuf/descriptor.proto and dev/restate/ext.proto
1d34bee 
The TS SDK seems to send incorrect file descriptors for google/protobuf/descriptor.proto
and dev/restate/ext.proto. This commit patches these files on the server as a temporary
solution until we remove the need for shipping Protobuf file descriptors.

This fixes restatedev#1262.
@tillrohrmann tillrohrmann mentioned this issue Mar 5, 2024
Merged
@slinkydeveloper
Copy link
Contributor

Can we close this?

@tillrohrmann
Copy link
Contributor Author

The problem has been fixed in the release-0.8 via 1d34bee.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tillrohrmann tillrohrmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tillrohrmann @slinkydeveloper