Unify metadata version type and remove nodes config singleton #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AhmedSoliman
force-pushed
the
pr1200
branch
2 times, most recently
from
4b91af9
to
699201d
Compare
tillrohrmann
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
Thanks for creating this PR @AhmedSoliman. The changes look good to me. +1 for merging.
I left a minor comment regarding the removal of NetworkAddress. I have a small PR where I used this type to instruct the node server to bind to unix domain sockets or tcp sockets. There it would still be useful.
| @@ -179,59 +84,52 @@ impl NodeConfig { | |||
|
|
|||
| #[derive(Debug, Clone, Eq, PartialEq, Hash, derive_more::Display)] | |||
| #[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))] | |||
| pub enum NetworkAddress { | |||
There was a problem hiding this comment.
Something like the NetworkAddress can still be useful to instruct the node server where to bind to. I guess it could contain the variants Uds and TcpSocketAddr, for example.
There was a problem hiding this comment.
Discussed in #1201
AhmedSoliman
changed the title
AhmedSoliman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unify metadata version type and remove nodes config singleton