MetadataManager init #1202
Merged
MetadataManager init #1202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
tillrohrmann
approved these changes
Feb 21, 2024
There was a problem hiding this comment.
Great work @AhmedSoliman. I like it a lot :-) +1 for merging.
crates/network/src/utils.rs
Outdated
| let channel = match address { | ||
| AdvertisedAddress::Uds(uds_path) => { | ||
| // dummy endpoint required to specify an uds connector, it is not used anywhere | ||
| Endpoint::try_from("/") |
There was a problem hiding this comment.
We have to put a valid uri with scheme and authority here. Otherwise tonic complains. So maybe http://127.0.0.1.
There was a problem hiding this comment.
Will fix. I think I just moved this code over, but it's a good catch.
crates/node/src/metadata.rs
Outdated
| Ok(*v) | ||
| } | ||
|
|
||
| // Returns when the metadata kind is at the provided version (or newer) |
There was a problem hiding this comment.
Comment seems not correct.
Comment on lines
+77
to
+89
| // Returns when the metadata kind is at the provided version (or newer) | ||
| pub async fn wait_for_version( | ||
| &self, | ||
| metadata_kind: MetadataKind, | ||
| min_version: Version, | ||
| ) -> Result<Version, ShutdownError> { | ||
| let mut recv = self.inner.write_watches[metadata_kind].receive.clone(); | ||
| let v = recv | ||
| .wait_for(|v| *v >= min_version) | ||
| .await | ||
| .map_err(|_| ShutdownError)?; | ||
| Ok(*v) | ||
| } |
crates/node/src/metadata.rs
Outdated
Comment on lines
194
to
201
| biased; | ||
| _ = cancellation_watcher() => { | ||
| info!("Metadata manager stopped"); | ||
| break; | ||
| } | ||
| Some(cmd) = self.inbound.recv() => { | ||
| self.handle_command(cmd) | ||
| } |
There was a problem hiding this comment.
Indentation looks a bit off. Might be GitHub.
There was a problem hiding this comment.
Macros and rustfmt don't like each other :)
Will indent.
| } | ||
|
|
||
| /// Start and wait for shutdown signal. | ||
| pub async fn run(mut self /*, network_sender: NetworkSender*/) -> anyhow::Result<()> { |
There was a problem hiding this comment.
Would the network_sender be used to actively fetch metadata updates from the metadata store?
There was a problem hiding this comment.
In a possible future, yes.
| info!("Metadata manager started"); | ||
|
|
||
| loop { | ||
| tokio::select! { |
This introduces `MetadataManager`, a node-level service that provides uniform access to different metadata kinds. This PR focuses on the nodes configuration only. `Metadata` is a cheaply cloneable handle that components can use to access metadata. `MetadataWriter` is only shared with components that can propose updates to the cached metadata. Additionally, this changes the node startup procedure to be one step closer to the original design. Worker attachment is only concerned with partition assignment and node IDs are directly fetched from NodesConfiguration. In this, nodes configuration will be statically created on startup if the bootstrap_cluster option is set (set by default at the moment). The server will fail to start if this is unset until we implement fetching nodes configuration from metadata store. The admin_address is not used anymore on startup but will be replaced with metadata address later for remote nodes config fetching.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MetadataManager init
This introduces
MetadataManager, a node-level service that provides uniform access to different metadata kinds. This PR focuses on the nodes configuration only.Metadatais a cheaply cloneable handle that components can use to access metadata.MetadataWriteris only shared with components that can propose updates to the cached metadata.Additionally, this changes the node startup procedure to be one step closer to the original design. Worker attachment is only concerned with partition assignment and node IDs are directly fetched from NodesConfiguration.
In this, nodes configuration will be statically created on startup if the bootstrap_cluster option is set (set by default at the moment). The server will fail to start if this is unset until we implement fetching nodes configuration from metadata store.
The admin_address is not used anymore on startup but will be replaced with metadata address later for remote nodes config fetching.
Stack created with Sapling. Best reviewed with ReviewStack.