Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename storage-rocksdb to partition-store #1476

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Rename storage-rocksdb to partition-store #1476

merged 2 commits into from
Apr 30, 2024

Conversation

AhmedSoliman
Copy link
Contributor

@AhmedSoliman AhmedSoliman commented Apr 26, 2024

Copy link

github-actions bot commented Apr 26, 2024

Test Results

 99 files  +4   99 suites  +4   8m 35s ⏱️ +48s
 84 tests +2   82 ✅ +2  2 💤 ±0  0 ❌ ±0 
216 runs  +4  210 ✅ +4  6 💤 ±0  0 ❌ ±0 

Results for commit bb01a0b. ± Comparison against base commit 05eb4ba.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. +1 for merging.

crates/partition-store/src/scoped_db.rs Outdated Show resolved Hide resolved
**IMPORTANT:** This breaks queries through datafusion until we workout how data fusion will shard queries across partitions.
@AhmedSoliman AhmedSoliman merged commit 7bf3d22 into main Apr 30, 2024
5 checks passed
@AhmedSoliman AhmedSoliman deleted the pr1476 branch April 30, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants