Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ingress] Parse the value of delaySec query param #1498

Merged
merged 1 commit into from
May 6, 2024

Conversation

igalshilman
Copy link
Contributor

This PR fixes a bug, where we previously tried parsing the queryParam name (key) instead of its value.

Before:

curl http://localhost:8080/greeter/greet/send?delaySec=1
{"message":"bad delaySec query parameter, must be a number: ParseIntError { kind: InvalidDigit }"}

After:

{
  invocationId: 'inv_1eNu2L3WKoEZ332IKyt2c6xNzg4HYl0SeR',
  executionTime: '2024-05-06T07:57:09.777000000Z'
}

This commit fixes a bug, where we previously tried parsing the
queryParam name (key) instead of its value.
@igalshilman igalshilman merged commit 46d3f67 into restatedev:main May 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants