Check for backward compatibility when validating the cluster marker #1619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillrohrmann
force-pushed
the
issues/1617
branch
from
97f638d
to
2aef2f9
Compare
slinkydeveloper
approved these changes
Jun 11, 2024
tillrohrmann
force-pushed
the
issues/1617
branch
from
2aef2f9
to
2bc2e5e
Compare
|
Sorry @slinkydeveloper, I needed to change a bit more since I realized that the cluster marker file also needs to contain the min forward compatible version since older version won't know about newer versions and therefore can't tell by themselves whether they are compatible or not. As part of this change, I simplified the whole logic by removing the compatibility map and replacing it with a single |
tillrohrmann
force-pushed
the
issues/1617
branch
from
2bc2e5e
to
53a957f
Compare
|
Thanks for the review @slinkydeveloper. Merging this PR now. |
Now the server checks whether it is backward-compatible with the data directory. If it encounters a version that either needs migration or cannot be migrated from, then it fails with a BackwardIncompatibility error. This fixes restatedev#1617.
tillrohrmann
force-pushed
the
issues/1617
branch
from
909e8f0
to
c0eb169
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the server checks whether it is backward-compatible with the data
directory. If it encounters a version that either needs migration or
cannot be migrated from, then it fails with a BackwardIncompatibility
error.
This fixes #1617.
This PR is based on #1616.