Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let shuffle always use get_next_message to support holey outboxes #1640

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Let shuffle always use get_next_message to support holey outboxes #1640

merged 2 commits into from
Jun 20, 2024

Commits on Jun 20, 2024

  1. Delete the node dir when wiping all 

    WipeMode::All will now delete the whole node base dir to also
remove a cluster marker file.

This fixes restatedev#1629.
    @tillrohrmann
    tillrohrmann committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    5ee9602 View commit details
    Browse the repository at this point in the history

  2. Let shuffle always use get_next_message to support holey outboxes 

    This commit changes the shuffle to always use get_next_message to read
the next outbox message. Before we were using get_message which was only
looking at a specific outbox entry. If this outbox entry was empty, then
the shuffle assumed that the outbox is empty. This did not work if the
outbox contained holes. Now with get_next_message, we always scan until
the next outbox message.

The change itself is trivial. In order to ensure that the change works,
this commit added a few unit tests to ensure the desired behaviour.

Note: With replacing get_message with get_next_message, the shuffle will
perform for every read a RocksDB scan operation. This is highly inefficient
and we should replace this logic with a tailing iterator.

This fixes restatedev#1639.
    @tillrohrmann
    tillrohrmann committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    1313e49 View commit details
    Browse the repository at this point in the history