Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[reorg] Stage 2 #1644

Merged
merged 2 commits into from
Jun 24, 2024
Merged

[reorg] Stage 2 #1644

merged 2 commits into from
Jun 24, 2024

Conversation

AhmedSoliman
Copy link
Contributor

@AhmedSoliman AhmedSoliman commented Jun 19, 2024

[reorg] Stage 2

  • Merge restate-network into restate-core
  • Merge NetworkError and NetworkSendError

Stack created with Sapling. Best reviewed with ReviewStack.

This was referenced Jun 19, 2024
@AhmedSoliman AhmedSoliman marked this pull request as ready for review June 19, 2024 15:50
Copy link

github-actions bot commented Jun 19, 2024

Test Results

102 files  ±0  102 suites  ±0   20m 34s ⏱️ -2s
 84 tests ±0   84 ✅ ±0  0 💤 ±0  0 ❌ ±0 
215 runs  ±0  215 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 06a1f46. ± Comparison against base commit daa7950.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. +1 for merging.

- Remove schema/schema-api (now in `restate_types::schema`)
- Remove cluster-controller and merge with restate-admin
- Use `prost-dto` for cluster-state
- Move networking types to `restate_types::net`
- Protobuf internal types reorg
- Merge `restate-network` into `restate-core`
- Merge NetworkError and NetworkSendError
@AhmedSoliman AhmedSoliman merged commit 06a1f46 into main Jun 24, 2024
7 checks passed
@AhmedSoliman AhmedSoliman deleted the pr1644 branch June 24, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants