[Bifrost] ReplicatedLoglet bifrost stubs #1683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bifrost providers are now initialized in two stages. An initialization that happens on startup to ensure all critical initialization and validation happens before server startup. After initialization, loglets will get a notification from watchdog to perform any background lazy initialization work if necessary. Benefits: - Removes the need to always "check if initialized" internally, or the use of "OnceLock" and other techniques to check if it's initialized or not. - Allows a potential validation step before server startup. Potentially fetching the metadata and validating all `LogletParams` for each provider in metadata against providers to reduce the chance of validation errors at construction time. - Allows construction of providers to be async without impacting providers' map access performance This PR also allows bifrost to be supplied a set of "Factories" to externalize how a loglet is constructed. This is crucial for the replicated-loglet since it depends on networking and other components that bifrost interface doesn't need to know about. A side benefit of this is that we can be very precise on which providers are _enabled_ for a given Bifrost instance. For example, InMemory loglet is now not allowed by default in restate-server binary (debateable if we should put it back or not)
Fixes tech-debt where open_db was not async (due to the requirement that bifrost provider construction was sync). This also uses BoxedLiveLoad in various places to simplify usage, cloning, and working with type-erased mapped `Live` objects.
This was referenced Jul 2, 2024
Empty stubs for client-side replicated-loglet. Everything is gated behind feature `replicated-loglet`
tillrohrmann
approved these changes
Jul 3, 2024
| @@ -46,6 +46,7 @@ pub enum Role { | |||
| Admin, | |||
| /// Serves the metadata store | |||
| MetadataStore, | |||
| #[cfg(feature = "replicated-loglet")] | |||
| /// Serves a log server for replicated loglets | |||
| LogServer, | |||
There was a problem hiding this comment.
A bit off-topic: If we want to support rolling back from this version, then we need to teach release-1.0 to ignore this role when deserializing it from the metadata-store. Right now it is panicking.
There was a problem hiding this comment.
Yes, there will definitely be an intermediate release before we can enable this. That release will be the safe fallback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Bifrost] ReplicatedLoglet bifrost stubs
Empty stubs for client-side replicated-loglet. Everything is gated behind feature
replicated-logletStack created with Sapling. Best reviewed with ReviewStack.