Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] Emit correct row count from CLI sql subcommand JSON mode #1685

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

pcholakov
Copy link
Contributor

Trivial little fix for something that caught my eye.

Before:

❯ restate sql "select value_utf8 from state limit 1" --jsonl
{"value_utf8":"{\"userId\":\"usr_101\",\"accounts\":[{\"accountId\":\"acc_10uhnxdeyrnKSVnXhgWouLo\",\"name\":\"updated-name\"}]}"}
0 rows. Query took 8.624792ms

After:

❯ ./target/debug/restate sql "select value_utf8 from state limit 1" --jsonl
{"value_utf8":"{\"accountId\":\"acc_10uhnxddRv3UE4UbJiWqbmi\",\"primaryOwnerUserId\":\"usr_101\",\"environments\":[],\"name\":\"integration-test-account-01j1sw6fqw8tcsn20jmeyrfx3g\"}"}
1 rows. Query took 9.157292ms

@pcholakov pcholakov changed the title Emit correct row count from CLI sql subcommand JSON mode [CLI] Emit correct row count from CLI sql subcommand JSON mode Jul 2, 2024
@pcholakov pcholakov merged commit aac2a1c into restatedev:main Jul 10, 2024
4 checks passed
@pcholakov pcholakov deleted the fix-cli-sql-json-row-count branch September 21, 2024 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants