Update CLI hyper/http dependencies #1739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackkleeman
force-pushed
the
update-tunnel
branch
from
dafc933
to
4bc2968
Compare
tillrohrmann
approved these changes
Jul 24, 2024
There was a problem hiding this comment.
Thanks for creating this PR @jackkleeman. The changes look good to me. I guess you've tried them out with the cloud, right? +1 for merging after resolving my minor comments.
jackkleeman
force-pushed
the
update-tunnel
branch
from
4bc2968
to
1e7c7a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will admit that this PR nearly broke me. Tunnel was heavily relying on the tower::Service semantics where poll_ready would be called repeatedly between HTTP requests, to process the trailers handshake that forms part of the protocol. To replace it I have used a tokio RWLock and a cancellation token