[Bifrost] Bifrost appends will wait for reconfiguration #1772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AhmedSoliman
force-pushed
the
pr1772
branch
2 times, most recently
from
95bd203
to
68b23bc
Compare
AhmedSoliman
force-pushed
the
pr1772
branch
2 times, most recently
from
33b0f5d
to
a8f4928
Compare
tillrohrmann
approved these changes
Jul 31, 2024
| let start = Instant::now(); | ||
| for sleep_dur in retry_iter.by_ref() { | ||
| self.fail_if_shutting_down()?; | ||
| tokio::time::sleep(sleep_dur).await; |
There was a problem hiding this comment.
Could we also wait for a logs metadata update to occur?
There was a problem hiding this comment.
I attempted to do that but it ended up being quite tricky and prone to racy select(). I'm leaning towards leaving it as is to avoid complexity until we find a good reason to avoid the short sleep.
Bifrost appends will wait for reconfiguration to complete. Additionally, log metadata will now handle empty segments correctly. An empty segment will be removed from the chain and replaced with the newly created one but with a higher segment index.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Bifrost] Bifrost appends will wait for reconfiguration
Bifrost appends will wait for reconfiguration to complete. Additionally, log metadata will now handle empty segments correctly. An empty segment will be removed from the chain and replaced with the newly created one but with a higher segment index.
Stack created with Sapling. Best reviewed with ReviewStack.