Fix rocksdb stall-detector sleep bug #1856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 16, 2024
This was referenced Aug 17, 2024
tillrohrmann
approved these changes
Aug 19, 2024
Comment on lines
-517
to
+518
| _ = tokio::time::sleep(manager.stall_detection_duration()), if !stalled => { | ||
| _ = &mut timeout, if !stalled => { |
There was a problem hiding this comment.
We are trying to save the costs to create one additional tokio::time::sleep::Sleep after it has fired, right? Did you see the costs of this operation somewhere?
There was a problem hiding this comment.
It showed up as an offender in my profiles, every bit helps :)
Cleanup and simplifying the code a litte, removes a few unnecessary clones. And most importantl, introduces `spawn_unmanaged()` that returns a runtime-agnostic TaskHandle<T>. Unmanaged tasks: - Created with an automatic cancellation token, code running in the task would still use the cancellation watcher as per usual - Tasks that return a value - Owner of TaskHandle can decide to cancel gracefully or abort. - Choice of runtime is still encapsulated within TaskCenter Other changes: - Important: Scheduling now works differently. Spawned tasks by default "inherit"s the parent's runtime. This reduces remote tokio scheduling and scopes partition processor workloads more accurately to their respective runtimes. - Direct and fast access to metadata() from `tc.metadata()` is now available. - Simplified task locals under one struct `TaskContext` - Moved telemetry submittion within task-center itself (used in subsequent PRs)
- Support background appender - Configurable base-dir, and other test parameters - Uses the new unmanaged TC tasks
Fixes an errornous use of sleep in a tokio::select, it overloads the timerwheel, wasting previous CPU cycles.
This was referenced Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix rocksdb stall-detector sleep bug
Fixes an errornous use of sleep in a tokio::select, it overloads the timerwheel, wasting previous CPU cycles.
Stack created with Sapling. Best reviewed with ReviewStack.