Update InvocationStatus v2 to use "iS" key prefix #1877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muhamadazmy
approved these changes
Aug 21, 2024
|
@muhamadazmy yes, this was added very recently indeed in #1828, and has never been a part of a tagged release. |
There was a problem hiding this comment.
I'm ok with this renaming, thanks for tackling it @pcholakov !
AhmedSoliman
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
Looks great. Thanks for initiating and addressing this @pcholakov.
|
Thanks folks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's use
InvocationStatusV2since both key prefixes will likely live on in the Restate codebase for a long time, even afterisbecomes officially unsupported sometime down the line.I've also renamed the storage protobuf message
NeoInvocationStatustoInvocationStatusV2without doing a mass search-and-replace; this PR only covers the long-lived mentions of the updated V2 invocation message and keys.