[Bifrost] Backward-friendly log-server role #1895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 5 files 5 suites 2m 23s ⏱️ Results for commit bfccd1d. ♻️ This comment has been updated with latest results. |
tillrohrmann
approved these changes
Aug 27, 2024
- Allow the server to parse the role "log-server" but it doesn't enable this as a default role when generating config. This allows next version to rollback without requiring manual nodes_config edits. - Adds new (backward-compatible) LogServerConfig stanza in nodes configuration with default `Provisioning` if unset.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Bifrost] Backward-friendly log-server role
Provisioningif unset.Stack created with Sapling. Best reviewed with ReviewStack.