[Compat] Fixes for a variety of backward compatibility issues #1920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses the known backward incompatibility issues with v1.0 including the issue introduced in #1692
AhmedSoliman
changed the title
pcholakov
approved these changes
Sep 3, 2024
Comment on lines
+144
to
+147
| #[serde(default)] | ||
| seal: Option<SealReason>, | ||
| #[serde(default)] | ||
| pub sealed: bool, |
There was a problem hiding this comment.
Simple as that! Thank you for fixing this.
|
Success! I can now go back and forth between 1.0.2 and the 1.1.0-main binaries on the same store with no errors, and the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Compat] Fixes for a variety of backward compatibility issues
Addresses the known backward incompatibility issues with v1.0 including the issue introduced in #1692
Stack created with Sapling. Best reviewed with ReviewStack.