Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address proc-macro-error advisory RUSTSEC-2024-0370 #1934

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Conversation

AhmedSoliman
Copy link
Contributor

Address proc-macro-error advisory RUSTSEC-2024-0370

The only dependency that currently needs proc-macro-error is err-derive used by arrow_convert which has not been updated yet. For our use, we only rely on it for restate's CLI so the risk is minimal but we will upgrade when a fix is available upstream. For the time being, we'll ignore this advisoryiserr-deriveused byarrow_convert` which has not been updated yet. For our use, we only rely on it for restate's CLI so the risk is minimal but we will upgrade when a fix is available upstream. For the time being, we'll ignore this advisory.

The only dependency that currently needs `proc-macro-error` is `err-derive` used by `arrow_convert` which has not been updated yet. For our use, we only rely on it for restate's CLI so the risk is minimal but we will upgrade when a fix is available upstream. For the time being, we'll ignore this advisory` is `err-derive` used by `arrow_convert` which has not been updated yet. For our use, we only rely on it for restate's CLI so the risk is minimal but we will upgrade when a fix is available upstream. For the time being, we'll ignore this advisory.
Copy link
Contributor

@pcholakov pcholakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Copy link
Contributor

@muhamadazmy muhamadazmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @AhmedSoliman for this fix :)

Copy link

github-actions bot commented Sep 9, 2024

Test Results

15 files  ±0  15 suites  ±0   20m 32s ⏱️ + 1m 1s
 6 tests ±0   6 ✅ ±0  0 💤 ±0  0 ❌ ±0 
18 runs  ±0  18 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3fbe812. ± Comparison against base commit 81d73da.

♻️ This comment has been updated with latest results.

@AhmedSoliman AhmedSoliman merged commit 74d7363 into main Sep 9, 2024
23 checks passed
@AhmedSoliman AhmedSoliman deleted the pr1934 branch September 9, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants