PolyBytes serde by proxy #1935
Merged
PolyBytes serde by proxy #1935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 9, 2024
This was referenced Sep 9, 2024
pcholakov
approved these changes
Sep 10, 2024
This allows TailState to be used in log-server as well
Introduces a serde-proxy for PolyBytes to allow passing `Record` in places where we need the value to be serializable. Serialization is a passthrough in case the sum type is already serialized
AhmedSoliman
force-pushed
the
pr1935
branch
from
ef367da
to
e00bfc2
Compare
muhamadazmy
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PolyBytes serde by proxy
Introduces a serde-proxy for PolyBytes to allow passing
Recordin places where we need the value to be serializable. Serialization is a passthrough in case the sum type is already serializedStack created with Sapling. Best reviewed with ReviewStack.