Add Source::Subscription to identify the invocation comes from a subscription
#2305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new feature `experimental_feature_kafka_ingress_next` for a cluster of issues to tackle in subsequent PRs (notably restatedev#1423 and restatedev#964)
There was a problem hiding this comment.
Thanks for creating this PR @slinkydeveloper. The changes look good to me. The one question I had was why PartitionProcessorRpcRequestId becomes a ResourceId. I imagined this id to be something internal that does not need to pay the price (additional overhead for evolvability) of being a ResourceId.
| @@ -45,6 +45,10 @@ pub struct IngressOptions { | |||
| /// back to a previous version. | |||
| #[cfg_attr(feature = "schemars", schemars(skip))] | |||
| pub experimental_feature_enable_separate_ingress_role: bool, | |||
|
|
|||
| /// Cluster of new features for the kafka ingress. | |||
There was a problem hiding this comment.
Are you gonna expand on what this cluster of new features are as you are tackling the other issues?
There was a problem hiding this comment.
I put it in the commit. I won't put them in the code until i get them done 😄 Also check https://github.com/orgs/restatedev/projects/15/views/13?sliceBy%5Bvalue%5D=ingress_kafka
tillrohrmann
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a leftover from the ingress PR of the past week.
I kept a generic name for the kafka ingress experimental feature, because I plan to bundle in there a bunch of other issue I plan to work on soon.