Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ServiceWorker scope header to web-ui response #2316

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

nikrooz
Copy link
Contributor

@nikrooz nikrooz commented Nov 18, 2024

In order to run ServiceWorkers in web-ui in browser the scope needs to be defined via Service-Worker-Allowed header from the web server serving the document.

Copy link

github-actions bot commented Nov 18, 2024

Test Results

  7 files  ±0    7 suites  ±0   4m 23s ⏱️ -21s
 47 tests ±0   46 ✅ ±0  1 💤 ±0  0 ❌ ±0 
182 runs  ±0  179 ✅ ±0  3 💤 ±0  0 ❌ ±0 

Results for commit 8838484. ± Comparison against base commit 7c0d13b.

♻️ This comment has been updated with latest results.

@nikrooz nikrooz merged commit 78d4d49 into main Nov 19, 2024
10 checks passed
@nikrooz nikrooz deleted the NN_add-service-worker-scope-header branch November 19, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants