Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compute partition key eagerly in ServiceId #387

Merged
merged 2 commits into from
May 15, 2023
Merged

Compute partition key eagerly in ServiceId #387

merged 2 commits into from
May 15, 2023

Conversation

tillrohrmann
Copy link
Contributor

This fixes #280.

@tillrohrmann
Copy link
Contributor Author

I've pushed another commit to get rid of duplicate information we pass to the storage layer. Sorry for the late push @slinkydeveloper.

@tillrohrmann
Compute partition key eagerly in ServiceId
79f8d5b 
This fixes #280.
@tillrohrmann
Pass in PartitionKey to storage layer via ServiceId type
026e5fe 
This commit removes the explicit passing of the partition key to the
storage layer because the ServiceId type already contains this information.
This simplifies the API slightly.

Moreover, this commit initializes the ServiceId with the stored partition key
instead of regenerating it from the keys field.
@tillrohrmann
Copy link
Contributor Author

Thanks for the review @slinkydeveloper. Merging this PR after GA gives green light.

@tillrohrmann tillrohrmann merged commit 026e5fe into restatedev:main May 15, 2023
@tillrohrmann tillrohrmann deleted the issue#280 branch May 15, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slinkydeveloper slinkydeveloper slinkydeveloper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should ServiceId cache the PartitionKey?
2 participants
@tillrohrmann @slinkydeveloper