Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge restate_journal into restate_common #541

Merged
merged 3 commits into from
Jun 27, 2023
Merged

Merge restate_journal into restate_common #541

merged 3 commits into from
Jun 27, 2023

Conversation

slinkydeveloper
Copy link
Contributor

@slinkydeveloper slinkydeveloper commented Jun 27, 2023 •
edited
Loading

Part of #420. Will merge the content of restate_common::types and restate_common::journal in the next PRs.

@slinkydeveloper slinkydeveloper added this to the 1B milestone Jun 27, 2023
tillrohrmann
tillrohrmann approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. +1 for merging.

@slinkydeveloper slinkydeveloper merged commit 55feb68 into restatedev:main Jun 27, 2023
@slinkydeveloper slinkydeveloper deleted the refactor_common/3 branch June 27, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tillrohrmann tillrohrmann tillrohrmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1B
Development

Successfully merging this pull request may close these issues.
2 participants
@slinkydeveloper @tillrohrmann