Merge restate_service_metadata types into restate_common.
#545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillrohrmann
approved these changes
Jun 27, 2023
… to define the Meta Storage API, and it's not part of the service_metadata/schema registry interfaces.
…s can be consumed by Options struct or by Meta REST APIs or by something else that needs a schema, it makes sense to keep the name of this feature generic here. Also add http to workspace deps.
slinkydeveloper
force-pushed
the
refactor_common/4
branch
from
3980b55
to
500d833
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the time being they fit here. In future we might reconsider this with #43. Part of #420