-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor common
#551
Merged
Merged
Refactor common
#551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillrohrmann
approved these changes
Jun 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. +1 for merging once the preceding PR is merged.
slinkydeveloper
force-pushed
the
issues/420
branch
from
June 30, 2023 12:20
7de7080
to
584bcf1
Compare
slinkydeveloper
force-pushed
the
issues/420
branch
from
July 4, 2023 13:58
584bcf1
to
99aa033
Compare
…comment) * `identifiers` contains the various identifiers * `invocation` contains the invocation model * `message` contains the various models used for internal messaging * `retries` contains the RetryPolicy and iter * `time` contains `MillisSinceEpoch` * `service_endpoint` contains the service endpoint metadata * `journal` contains entries, raw and enriched and journal metadata
slinkydeveloper
force-pushed
the
issues/420
branch
from
July 6, 2023 13:33
be3cd6c
to
647df5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #420. Depends on #536