Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add protoc-gen-go-restate #18

Merged
merged 4 commits into from
Aug 12, 2024
Merged

Add protoc-gen-go-restate #18

merged 4 commits into from
Aug 12, 2024

Conversation

jackkleeman
Copy link
Contributor

protoc-gen-go-restate/restate.go is where the meat is, but its very ugly - heavily borrowed from protoc-gen-go-grpc

@jackkleeman jackkleeman force-pushed the codegen branch 2 times, most recently from 7fadecf to 62de0e0 Compare July 30, 2024 10:12
Copy link
Contributor

@slinkydeveloper slinkydeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I have some minor comments here and there about protobuf itself :)

proto/dev/restate/sdk/go.proto Outdated Show resolved Hide resolved
proto/dev/restate/sdk/go.proto Outdated Show resolved Hide resolved
proto/dev/restate/sdk/go.proto Outdated Show resolved Hide resolved
proto/dev/restate/sdk/go.proto Show resolved Hide resolved
Comment on lines 20 to 27
- local:
- docker
- run
- --pull=always
- -i
- ghcr.io/restatedev/protoc-gen-go-restate:latest
out: .
opt: paths=source_relative
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we publish binaries for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do in followup PR

examples/codegen/main.go Show resolved Hide resolved
buf.yaml Show resolved Hide resolved
protoc-gen-go-restate/README.md Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Aug 9, 2024

Test Results

  5 files  ±0    5 suites  ±0   7m 5s ⏱️ -36s
 41 tests ±0   41 ✅ ±0  0 💤 ±0  0 ❌ ±0 
101 runs  ±0  101 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 06bd0ad. ± Comparison against base commit adafb6e.

♻️ This comment has been updated with latest results.

@jackkleeman jackkleeman merged commit 8eb988a into main Aug 12, 2024
3 checks passed
@jackkleeman jackkleeman deleted the codegen branch August 12, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants