-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add protoc-gen-go-restate #18
Conversation
7fadecf
to
62de0e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, I have some minor comments here and there about protobuf itself :)
protoc-gen-go-restate/README.md
Outdated
- local: | ||
- docker | ||
- run | ||
- --pull=always | ||
- -i | ||
- ghcr.io/restatedev/protoc-gen-go-restate:latest | ||
out: . | ||
opt: paths=source_relative |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we publish binaries for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will do in followup PR
protoc-gen-go-restate/restate.go
is where the meat is, but its very ugly - heavily borrowed from protoc-gen-go-grpc