Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TerminalErrorf #30

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Add TerminalErrorf #30

merged 2 commits into from
Aug 21, 2024

Conversation

slinkydeveloper
Copy link
Contributor

Fix #29

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 20, 2024 •
edited
Loading

Test Results

  5 files  ±0    5 suites  ±0   2m 13s ⏱️ -5s
 41 tests ±0   41 ✅ ±0  0 💤 ±0  0 ❌ ±0 
101 runs  ±0  101 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 30371bd. ± Comparison against base commit 333963c.

♻️ This comment has been updated with latest results.

jackkleeman
jackkleeman approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@jackkleeman jackkleeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you check for usages in this repo of term(fmt.errorf) and convert them? thx

@jackkleeman jackkleeman merged commit 16fb256 into main Aug 21, 2024
3 checks passed
@jackkleeman jackkleeman deleted the issues/29 branch August 21, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackkleeman jackkleeman Awaiting requested review from jackkleeman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

restate.TerminalErrorf()
2 participants
@slinkydeveloper @jackkleeman