Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow more method signatures in .Reflect() #33

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Allow more method signatures in .Reflect() #33

merged 2 commits into from
Aug 21, 2024

Conversation

jackkleeman
Copy link
Contributor

@jackkleeman jackkleeman commented Aug 20, 2024 •
edited
Loading

Fixes #31

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 20, 2024 •
edited
Loading

Test Results

  5 files  ±0    5 suites  ±0   2m 18s ⏱️ -1s
 41 tests ±0   41 ✅ ±0  0 💤 ±0  0 ❌ ±0 
101 runs  ±0  101 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 8259ee1. ± Comparison against base commit f505c4c.

♻️ This comment has been updated with latest results.

@jackkleeman jackkleeman force-pushed the fn-relax branch 3 times, most recently from 1ddcf55 to 86965d4 Compare August 21, 2024 07:56
Base automatically changed from codec-panic to main August 21, 2024 10:40
@jackkleeman jackkleeman force-pushed the fn-relax branch 4 times, most recently from 88f456a to a8ab706 Compare August 21, 2024 15:09
@jackkleeman jackkleeman changed the title experiment: more permissive reflection Allow more method signatures in .Reflect() Aug 21, 2024
@slinkydeveloper
Copy link
Contributor

I think you might be able to use some of the new supported signatures in many test-services

@jackkleeman jackkleeman merged commit 9ca5263 into main Aug 21, 2024
3 checks passed
@jackkleeman jackkleeman deleted the fn-relax branch August 21, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slinkydeveloper slinkydeveloper slinkydeveloper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow in restate.Reflect signatures wihout errors
2 participants
@jackkleeman @slinkydeveloper