Introduce deterministic random #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slinkydeveloper
changed the title
slinkydeveloper
force-pushed
the
issues/155
branch
from
fd9ad35
to
332895f
Compare
slinkydeveloper
changed the title
igalshilman
approved these changes
Dec 22, 2023
| private final Syscalls syscalls; | ||
| private boolean seedInitialized = false; | ||
|
|
||
| RestateRandom(long randomSeed, Syscalls syscalls) { |
There was a problem hiding this comment.
nit: Should this be just BooleanSupplier ?
There was a problem hiding this comment.
I prefer to use Syscalls here, it makes a bit more clear this code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #155.
Please note that because the JDK
UUIDclass doesn't have a way to specify a seed to its internal RNG, we can't use thisRandominstance to generate uuids. Perhaps we can re-iterate on this later by adding a method ourselves?