Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of jackson in sdk-common ingress client #328

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

slinkydeveloper
Copy link
Contributor

@slinkydeveloper slinkydeveloper commented May 22, 2024

Remove the other usage of jackson in sdk-common, depends on restatedev/restate#1542

Copy link
Contributor

github-actions bot commented May 22, 2024

Test Results

 48 files  ±0   48 suites  ±0   2m 55s ⏱️ -12s
738 tests ±0  716 ✅  - 13  8 💤  - 1  14 ❌ +14 
738 runs   - 1  716 ✅  - 14  8 💤  - 1  14 ❌ +14 

For more details on these failures, see this check.

Results for commit 5219f3f. ± Comparison against base commit 2b5d8e4.

This pull request removes 7 and adds 7 tests. Note that renamed tests count towards both.
dev.restate.e2e.NodeWorkflowAPITest ‑ Workflow cannot be submitted more than once
dev.restate.sdk.common.CoreSerdesTest ‑ Byte: -111
dev.restate.sdk.common.CoreSerdesTest ‑ Double: 0.5184783207844548
dev.restate.sdk.common.CoreSerdesTest ‑ Float: 0.62707436
dev.restate.sdk.common.CoreSerdesTest ‑ Integer: 1461953937
dev.restate.sdk.common.CoreSerdesTest ‑ Long: -4178086973975213529
dev.restate.sdk.common.CoreSerdesTest ‑ Short: 13800
dev.restate.sdk.common.CoreSerdesTest ‑ Byte: -89
dev.restate.sdk.common.CoreSerdesTest ‑ Double: 0.9046595808179864
dev.restate.sdk.common.CoreSerdesTest ‑ Float: 0.26799035
dev.restate.sdk.common.CoreSerdesTest ‑ Integer: 1669200667
dev.restate.sdk.common.CoreSerdesTest ‑ Long: 5344576980110012853
dev.restate.sdk.common.CoreSerdesTest ‑ Short: 11065
dev.restate.sdk.serde.jackson.JacksonSerdesTest ‑ [Till, Francesco]

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant