Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Serde nullability annotations #361

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Fix Serde nullability annotations #361

merged 1 commit into from
Jul 26, 2024

Conversation

slinkydeveloper
Copy link
Contributor

Fix #357

  • Bump to JSpecify 1.0
  • Fix Serde nullability annotations

Fix Serde nullability annotations
Copy link
Contributor

github-actions bot commented Jul 26, 2024

Test Results

 50 files  ±0   50 suites  ±0   7m 37s ⏱️ -7s
759 tests +1  752 ✅ +1  7 💤 ±0  0 ❌ ±0 
760 runs  ±0  753 ✅ ±0  7 💤 ±0  0 ❌ ±0 

Results for commit cbdf5d9. ± Comparison against base commit 4455eec.

This pull request removes 6 and adds 7 tests. Note that renamed tests count towards both.
dev.restate.sdk.TestSerdesTest ‑ Byte: 94
dev.restate.sdk.TestSerdesTest ‑ Double: 0.23987722093183717
dev.restate.sdk.TestSerdesTest ‑ Float: 0.30495483
dev.restate.sdk.TestSerdesTest ‑ Integer: 437733994
dev.restate.sdk.TestSerdesTest ‑ Long: -7309916266831488259
dev.restate.sdk.TestSerdesTest ‑ Short: -7334
dev.restate.sdk.TestSerdesTest ‑ Byte: -43
dev.restate.sdk.TestSerdesTest ‑ Double: 0.31112775963416117
dev.restate.sdk.TestSerdesTest ‑ Float: 0.15802449
dev.restate.sdk.TestSerdesTest ‑ Integer: -1992689252
dev.restate.sdk.TestSerdesTest ‑ Long: -3176588736170124200
dev.restate.sdk.TestSerdesTest ‑ Short: 1097
dev.restate.sdk.serde.jackson.JacksonSerdesTest ‑ [Till, Francesco]

♻️ This comment has been updated with latest results.

@slinkydeveloper slinkydeveloper merged commit aa33ad4 into main Jul 26, 2024
5 checks passed
@slinkydeveloper slinkydeveloper deleted the issues/357 branch July 26, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Awakeable handle annotated with @NotNull but needs null for VOID types
1 participant