Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement run retry policy #375

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Implement run retry policy #375

merged 2 commits into from
Sep 9, 2024

Conversation

slinkydeveloper
Copy link
Contributor

@slinkydeveloper slinkydeveloper commented Sep 4, 2024 •
edited
Loading

Fix #373

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024 •
edited
Loading

Test Results

  5 files  ±0    5 suites  ±0   3m 12s ⏱️ +6s
 46 tests +1   46 ✅ +1  0 💤 ±0  0 ❌ ±0 
117 runs  +3  117 ✅ +3  0 💤 ±0  0 ❌ ±0 

Results for commit e79cd97. ± Comparison against base commit dea6bae.

This pull request removes 2 and adds 3 tests. Note that renamed tests count towards both. 
dev.restate.sdktesting.tests.SideEffect ‑ sideEffectFlush(Client)
dev.restate.sdktesting.tests.UserErrors ‑ sideEffectWithEventualSuccess(Client)

dev.restate.sdktesting.tests.RunFlush ‑ flush(Client)
dev.restate.sdktesting.tests.RunRetry ‑ withExhaustedAttempts(Client)
dev.restate.sdktesting.tests.RunRetry ‑ withSuccess(Client)

♻️ This comment has been updated with latest results.

@slinkydeveloper
Squashed 'sdk-core/src/main/service-protocol/' changes from 1898426f.…
eea384b 
….0d6b476e

0d6b476e Update retry count comment
0d35aad2 Add fields for the Side effect retry feature (#95)
89224c68 Add buf configuration

git-subtree-dir: sdk-core/src/main/service-protocol
git-subtree-split: 0d6b476ea4bb78253fb21edcf151d9c401aecdb1
@slinkydeveloper
Run retry policy
e79cd97
@slinkydeveloper slinkydeveloper merged commit 7d4c2f9 into main Sep 9, 2024
5 checks passed
@slinkydeveloper slinkydeveloper deleted the issues/373 branch September 9, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose side effect retry feature
1 participant
@slinkydeveloper