Switch to HTTP based error codes #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igalshilman
force-pushed
the
fix_error_code
branch
from
e6189a4
to
88eba0f
Compare
src/types/errors.ts
Outdated
Comment on lines
23
to
25
| export enum RestateErrorCodes { | ||
| JOURNAL_MISMATCH = 32, | ||
| PROTOCOL_VIOLATION = 33, |
There was a problem hiding this comment.
You also need to get rid of those and replace them with 570/571, as described here restatedev/service-protocol@61ae44b
igalshilman
force-pushed
the
fix_error_code
branch
from
3ac9957
to
43ed855
Compare
This commit replaces the gRPC based ErrorCode enum, with the HTTP based (integer) status code.
igalshilman
force-pushed
the
fix_error_code
branch
from
43ed855
to
c08b4c0
Compare
|
Since e2e tests are currently influx, I'll go ahead an merge that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the gRPC based ErrorCode enum, with the HTTP based (integer) status code.