Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let goreleaser use custom release notes #244

Merged
merged 1 commit into from
Jul 9, 2023

Conversation

MichaelEischer
Copy link
Member

What is the purpose of this change? What does it change?

If the changelog generation is disabled in goreleaser, this also ignores custom release notes passed in via the command line (see https://goreleaser.com/customization/changelog/). Thus keep the default changelog configuration.

Was the change discussed in an issue or in the forum before?

No.

Checklist

  • I have enabled maintainer edits for this PR
  • [ ] I have added tests for all changes in this PR
  • [ ] I have added documentation for the changes (in the manual)
  • [ ] There's a new file in changelog/unreleased/ that describes the changes for our users (template here)
  • I have run gofmt on the code in all commits
  • All commit messages are formatted in the same style as the other commits in the repo
  • I'm done, this Pull Request is ready for review

If the changelog generation is disabled in goreleaser, this also ignores
custom release notes passed in via the command line. Thus keep the
default changelog configuration.
Copy link
Member

@fd0 fd0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fd0 fd0 merged commit c38e18b into restic:master Jul 9, 2023
@MichaelEischer MichaelEischer deleted the missing-release-notes-on-release branch July 9, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants