Fixes GH-916 by falling back to the old HTTP 413 Error Code if not present #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving between Node 0.12 and 4 introduces different http status code messages for the request body size is too large error (413). This should normalize between the two, picking the one that is not undefined.
|
I'd like to get this out as 4.0.3, so no one else has issues with receiving a 500 instead of a 413. |
| // Between Node 0.12 and 4 http status code messages changed | ||
| // RequestEntityTooLarge was changed to PayloadTooLarge | ||
| // this check is to maintain backwards compatibility | ||
| if (PayloadTooLargeError !== undefined) { |
There was a problem hiding this comment.
Great work, consider using process.version to switch on these error codes.
There was a problem hiding this comment.
I knew there had to be a way to look that up.
Now that I have this in here, I think it might be less brittle to use the Error names, since the http code names actually changed in iojs 3. And if someone is using Restify with iojs 3, we should not break that.
|
@micahr looks good, feel free to merge. Thanks for the quick fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add compatibility with Node 4 for Http Status Codes
Moving between Node 0.12 and 4 introduces different http status code
messages for the request body size is too large error (413). This should
normalize between the two, picking the one that is not undefined.
Fixes #916