Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make BuildUrl an extension #2039

Merged
merged 10 commits into from
Mar 31, 2023
Merged

Make BuildUrl an extension #2039

merged 10 commits into from
Mar 31, 2023

Conversation

alexeyzimarev
Copy link
Member

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 29, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: bb20dc8
Status: ✅  Deploy successful!
Preview URL: https://1d9038d3.restsharp.pages.dev
Branch Preview URL: https://buildurl.restsharp.pages.dev

View logs

@alexeyzimarev alexeyzimarev merged commit 159c8a7 into dev Mar 31, 2023
@repo-ranger repo-ranger bot deleted the buildurl branch March 31, 2023 09:36
@nesc58
Copy link

nesc58 commented Mar 31, 2023

RestSharp should be versioned with semantic versioning.

Changing ParametersCollection is a breaking change
new ParametersCollection(...) is not longer available. It must be replaced with new DefaultParameters(...) or new RequestParameters(...).

The changes are fine to me and reasonable but the version should be changed to 110.0.0. This will make the breaking change clear because it is not only a bug fix or added functionality. e.g. I am using version patterns like

<PackageVersion Include="RestSharp" Version="[109.0.1, 110.0.0)" />

to prevent other libraries installing a potential breaking version. The current change will break this pattern.

Is this fine for you to change the version to 110.0.0?

@alexeyzimarev
Copy link
Member Author

Yes, the plan is to release the new major.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants