COM Helpers and Various Constants #100
Conversation
|
As issue #17 states, everything is being split out of |
| pub QueryInterface: unsafe extern "system" fn( | ||
| This: *mut IMMDevice, | ||
| RIDL!( | ||
| interface IMMDevice(IMMDeviceVtbl) { |
There was a problem hiding this comment.
Could you change the COM definitions to also inherit from their base COM classes, like the way I did with AsyncIUnknown?
There was a problem hiding this comment.
No problem, it's taken care of.
|
I moved all the things I added or changed into the appropriate modules. |
| @@ -2,6 +2,8 @@ | |||
| // Licensed under the MIT License <LICENSE.md> | |||
| //! this ALWAYS GENERATED file contains the definitions for the interfaces | |||
| //1627 | |||
| use unknwnbase::*; | |||
There was a problem hiding this comment.
If I try to do ::IUnknown the RIDL macro doesn't compile, so I need to import the type manually. Would it be better to change the macro so that it supports absolute paths?
There was a problem hiding this comment.
It would be better to fix the macro.
There was a problem hiding this comment.
This should be fixed now.
|
Thanks, could you rebase everything and maybe |
- Adds the WAVE_FORMAT_* constants form mmreg.h. - Adds more COM helper functions to IMMDevice, IAudioClient, and IAudioRenderClient. (+2 squashed commit) Squashed commit: [2d1d204] IMMDeviceEnumerator Helpers - Adds and implementation for IMMDeviceEnumerator with helper methods to call the functions in its vtable. - Adds the COINIT_* constants. [1b9bcb6] System Timer Resolution Methods - Adds timeBeginPeriod() and timeEndPeriod() ot winmm. - Adds SetPriorityClass() to kernel32-sys. - Adds a mess of constants from winbase.h.
- Changes the existing RILD declarations to inherit from IUnknown rather than re-declaring the interface for each one. Convert Manual COM Declarations to RIDL Convert Manual COM Declarations to RIDL
Move Constants and Types Into Separate Modules
- Changes the RIDL! macro to qualify the parent type with the absolute path so that the type doesn't need to be imported with a use statement.
|
Rebased and squashed. Let me know if it looks like I did anything wrong, I don't normally rebase/squash in my projects so I wasn't familiar with the process. |
SetPriorityClass()to kernel32-sys.timeBeginPeriod()andtimeEndPeriod()to winmm-sys.I left the RIDL declarations in the main winapi lib file, but if you want them each in a separate file like you did with unknownbase.rs then I can move them over.