Add NCryptFreeObject #319
Add NCryptFreeObject #319
Conversation
|
Don't forget to add ncrypt to the dev dependencies of winapi so CI can actually test building it. |
|
Fixed! |
We have to pull some ncrypt stuff in temporarily until retep998/winapi-rs#319 lands.
|
Ping |
|
This PR will need to be updated to the winapi 0.3 new world order. #316 |
|
Updated! The mingw dlls have not been added anywhere since the appropriate crates haven't been created yet. |
|
Could you rebase once a nightly comes out with rust-lang/rust#37361 so this PR can be tested properly? |
|
Sure, will do. |
sfackler
force-pushed
the
patch-2
branch
2 times, most recently
from
ca30d4a
to
f4b86ec
Compare
|
Updated, but looks like the GNU build is failing due to the missing library shims. |
| @@ -14,3 +14,4 @@ | |||
| #[cfg(feature = "um-wincon")] pub mod wincon; | |||
| #[cfg(feature = "um-wingdi")] pub mod wingdi; | |||
| #[cfg(feature = "um-winnt")] pub mod winnt; | |||
| #[cfg(feature = "um-ncrypt")] pub mod ncrypt; | |||
| @@ -69,7 +73,9 @@ headers = ["headers-shared", "headers-um", "headers-vc"] | |||
| "vc-vcruntime" = [] | |||
| libraries = [ | |||
| "kernel32", | |||
| "ole32" | |||
| "ole32", | |||
| "ncrypt" | |||
There was a problem hiding this comment.
I think you might have forgot about this when updating.
| @@ -56,6 +59,7 @@ headers = ["headers-shared", "headers-um", "headers-vc"] | |||
| "um-combaseapi" = ["shared-basetsd", "shared-minwindef", "shared-wtypesbase", "um-objidlbase", "ole32"] | |||
| "um-consoleapi" = ["shared-minwindef", "um-wincon", "um-winnt", "kernel32"] | |||
| "um-minwinbase" = ["shared-ntstatus"] | |||
| "um-ncrypt" = ["shared-basetsd", "shared-sspi"] | |||
There was a problem hiding this comment.
This should also depend on "ncrypt" because it has functions from that library.
|
Updated! |
|
I added crates in the |
|
Updated! |
No description provided.