Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libraries for 0.3 #374

Closed
wants to merge 4 commits into from
Closed

Update libraries for 0.3 #374

wants to merge 4 commits into from

Conversation

schulzch
Copy link

This PR does:

  • Parse list of libraries from Cargo.toml (replaces LIBS in build.rs).
  • Adds more libraries, based on directory names in lib

Should be in line with #316.

@schulzch
Copy link
Author

CI errors are weird (missing libraries on gcc and unknown error for rust 1.0)

@retep998
Copy link
Owner

toml depends on serde which I believe at some point released a version which could not be parsed by older Cargo. Therefore toml would significantly raise the minimum Rust requirement for winapi which I do not want to do at this time. Also I don't like depending on external crates anyway (they'll steal all my downloads!).

@schulzch
Copy link
Author

Ok, I'll remove that part.

I've been playing around with using bindgen on windows.h and it works okay-ish, except for cast-style constants like #define SOME_CONST ((int) 3). I'll push it later on. What are your thoughts on automation in general?

@retep998
Copy link
Owner

I don't mind people using bindgen to help them write winapi bindings as long as the end result is accurate and in the correct style.

@schulzch
Copy link
Author

Done. CI issue seems to be related to AppVeyor (missing libraries).

In case you are interested in experiments with ´rustgen` see winapi-gen-rs.

@retep998
Copy link
Owner

retep998 commented Mar 2, 2017

PR has rather major conflicts.

@retep998
Copy link
Owner

This PR basically has no point anymore given the way that library dependencies are now handled.

@retep998 retep998 closed this Mar 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants