Finishing off the rest of src/*.rs #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are some problems with porting over some of the interfaces where they don't have a UUID in the header describing them. Specifically: Is there something I'm missing or should these be declared differently? |
|
This should now build as I'm using all-zeroes for missing UUIDs and I cleaned up some other issues. Also, I redid |
Susurrus
force-pushed
the
even_moar
branch
2 times, most recently
from
4f634b1
to
2c9e63e
Compare
|
@retep998 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this it's only the source files in
lib/that need to be ported.98eab59 needs careful review since the datatype should actually be a
UNION2!, but I'm not certain how to do that.8a1d180 I also need some help with since I didn't figure out how to use
UNION2!to portsockaddr_in6.Note that this builds off of #448 and #454, which is why it looks so huge. This is actually only the commits since 2233a23.