Added missing FileVersionInfo functionality #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added missing functions to winver.rs Reordered winver.rs to match the order of the original header Replaced explicit pointers in winver.rs with their concise winapi equivalents Created versrc.rs and populated it with its constants and a struct type
Sorenon
changed the title
roblabla
suggested changes
Nov 27, 2020
There was a problem hiding this comment.
Needs a few fixes.
-
Organization of code
- All definitions go into the source file that directly maps to the header the definition is from:
⚠️ versrc doesn't match header file nameverrsrc.h.
- Definitions are defined in the same order as they are in the original header: ✔️
- All definitions go into the source file that directly maps to the header the definition is from:
-
Extern functions
- The calling convention specified should be the one for 32bit: ✔️
-
Constants
- Names are correct ✔️
- Values are correct
⚠️ one small issue. - Types are correct: All the constants are meant to be used in the VS_FIXEDFILEINFO, which is all DWORD: ✔️
-
Structs
- Wrapped in the STRUCT! macro, matches C structure: ✔️
Co-authored-by: Robin Lambertz <[email protected]>
Co-authored-by: Robin Lambertz <[email protected]>
Co-authored-by: Robin Lambertz <[email protected]>
Co-authored-by: Robin Lambertz <[email protected]>
roblabla
approved these changes
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing functions to winver.rs
Reordered winver.rs to match the order of the original header
Replaced explicit pointers in winver.rs with their concise winapi equivalents
Created versrc.rs from versrc.h and populated it with the constants and struct type