Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some functions from Msi and MsiQuery #957

Open
wants to merge 5 commits into
base: 0.3
Choose a base branch
from

Conversation

roblabla
Copy link

Adds some functions from Msi.h and MsiQuery.h, useful when writing MSI Custom Actions.

Those bindings were written using the 10.0.19041.0 headers.

Copy link
Contributor

@MaulingMonkey MaulingMonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

  • Organization of code
    • All definitions go into the source file that directly maps to the header the definition is from.
      • C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\um\Msi.h
      • C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\um\MsiQuery.h
    • Definitions are defined in the same order as they are in the original header.
  • Imports
    • Are sorted in asciibetical order.
  • Extern functions
    • ABIS are correct (WINAPI = "system")
    • Names are correct (functions, parameters)
    • Parameter types are correct
    • Return types are correct
  • Enums
    • Enum and enumerant names are correct
    • Enum values are correct
  • Simple types
    • Names are correct
    • Types are correct

@roblabla roblabla mentioned this pull request Dec 4, 2020
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants