Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving packaging from webpack to rollup #754

Open
deontologician opened this issue Aug 16, 2016 · 5 comments
Open

Consider moving packaging from webpack to rollup #754

deontologician opened this issue Aug 16, 2016 · 5 comments

Comments

@deontologician
Copy link
Contributor

Since we're in es6 (soon to also be typescript) it would be nice to take advantage of rollup's benefits in bundle size.

Right now it's not too feasible since we'd want rxjs to come along for the ride, and their add/operator/* modules aren't handled properly by rollup at the moment: ReactiveX/rxjs#1671

Adding this to Proposed so we can consider it later

@intellix
Copy link

Webpack 2 has tree shaking, thoughts on that?

@deontologician
Copy link
Contributor Author

I have webpack 2 working in my typescript branch, it's probably fine for
the medium term. The way we use our libraries, tree shaking isn't a huge
benefit. The bigger benefit of rollup is that it gets rid of the entire
module loading system and puts everything into the same scope. It cuts down
on import overhead which webpack 2 still doesn't do

On Tue, Aug 16, 2016, 01:02 Dominic Watson [email protected] wrote:

Webpack 2 has tree shaking, thoughts on that?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#754 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAFVs6S9Yo5seXU1fpQjt9KplVNbdLpks5qgW6AgaJpZM4Jk_aW
.

@vramana
Copy link
Contributor

vramana commented Aug 16, 2016

Webpack has plans to implement the rollup functionality. See webpack/webpack#2873

@deontologician
Copy link
Contributor Author

That would be really sweet if they did that. There's definitely a lot more of a community behind webpack

@tvld
Copy link

tvld commented Aug 24, 2016

We integrate tightly using webpack and vue.js - good combo ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants