Merge pull request #657 from joshuaprince/sign-editor

Properly read isFrontText in sign edit wrappers
retrooper · Jan 19, 2024 · d6ee3b3 · d6ee3b3
2 parents 36b7375 + 7b800a9
commit d6ee3b3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/...va/com/github/retrooper/packetevents/wrapper/play/client/WrapperPlayClientUpdateSign.java b/...va/com/github/retrooper/packetevents/wrapper/play/client/WrapperPlayClientUpdateSign.java
@@ -30,7 +30,7 @@
 public class WrapperPlayClientUpdateSign extends PacketWrapper<WrapperPlayClientUpdateSign> {
     private Vector3i blockPosition;
     private String[] textLines;
-    private boolean isFrontText = true;
+    private boolean isFrontText;
 
     public WrapperPlayClientUpdateSign(PacketReceiveEvent event) {
         super(event);
@@ -55,6 +55,8 @@ public void read() {
         }
         if (serverVersion.isNewerThanOrEquals(ServerVersion.V_1_20)) {
             isFrontText = readBoolean();
+        } else {
+            isFrontText = true;
         }
         textLines = new String[4];
         for (int i = 0; i < 4; i++) {

diff --git a/...om/github/retrooper/packetevents/wrapper/play/server/WrapperPlayServerOpenSignEditor.java b/...om/github/retrooper/packetevents/wrapper/play/server/WrapperPlayServerOpenSignEditor.java
@@ -26,7 +26,7 @@
 
 public class WrapperPlayServerOpenSignEditor extends PacketWrapper<WrapperPlayServerOpenSignEditor> {
     private Vector3i position;
-    private boolean isFrontText = true;
+    private boolean isFrontText;
 
     public WrapperPlayServerOpenSignEditor(PacketSendEvent event) {
         super(event);
@@ -50,6 +50,8 @@ public void read() {
         }
         if (serverVersion.isNewerThanOrEquals(ServerVersion.V_1_20)) {
             isFrontText = readBoolean();
+        } else {
+            isFrontText = true;
         }
     }