Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix legacy mappings for grass and tallgrass variants #1053

Open
wants to merge 2 commits into
base: 2.0
Choose a base branch
from

Conversation

Axionize
Copy link

@Axionize Axionize commented Nov 4, 2024

No description provided.

@Axionize
Copy link
Author

Axionize commented Nov 4, 2024

Fixes #1052

@Axionize
Copy link
Author

Axionize commented Nov 5, 2024

@booky10

@booky10
Copy link
Collaborator

booky10 commented Nov 5, 2024

There is a syntax error in your mappings, see build logs

@Axionize Axionize force-pushed the fix-legacy-grass-and-tallgrass-mappings branch from e859dd5 to d1024ed Compare November 5, 2024 22:25
@Axionize
Copy link
Author

Axionize commented Nov 5, 2024

@booky10 fixed

@Axionize
Copy link
Author

Axionize commented Nov 8, 2024

An upstream issue in grim hinges on this being fixed. I'd appreciate this being done as soon as you have time.

@booky10
Copy link
Collaborator

booky10 commented Nov 8, 2024

I'll hopefully get this done later today, I still want to do some testing before merging to ensure this works properly

@Axionize
Copy link
Author

Items are similar broken/incorrect just like the blocks. An additional hurdle is that item mappings also don't appear to use blockstates? (or I guess itemstates?).

For example 175:2 corresponds to tallgrass and 175:3 corresponds to large ferns. Every 175 variant is considered a large fern. I don't really care since I only care about the hitboxes of these blocks (and they're all the same) but someone else down the line might.

Can we make item mappings work with data states?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants