Fix missing Equipment body slot #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1, can confirm that this fixes wrapping ENTITY_EQUIPMENT packets, and fixed horse and wolf armor causing the kick described in #806 on my 1.20.6 server. I've been running the fix without any similar issues for a few days now. It's very easy to reproduce the original bug and show this fixes it: if (event.getPacketType() == PacketType.Play.Server.ENTITY_EQUIPMENT) {
WrapperPlayServerEntityEquipment w = new WrapperPlayServerEntityEquipment(event);
} |
joshuaprince
added a commit
to joshuaprince/packetevents
that referenced
this pull request
Jun 19, 2024
Merged as of c591335
|
Ahh, it was that simple! I'll test this tomorrow on 1.8 and some other versions to see how that's being dealt with. Would love for this to be fixed before the next release. |
|
Thanks for looking into this troopah! This fixes a lot of issues I am having! |
|
No worries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #806.
I am not sure how to handle backward compatibility if it is needed in this case at all, as I am not sure how MC handled horse armor before 1.20.5...