-
-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LimboAPI and FastMOTD support for Velocity #853
Conversation
...y/src/main/java/io/github/retrooper/packetevents/manager/InternalVelocityPacketListener.java
Outdated
Show resolved
Hide resolved
bba0734
to
4d5ca11
Compare
Does this actually work? |
Yep, but require a bit cleanup. |
4d5ca11
to
6d0b7f8
Compare
I'll happily add to the current progress, but getting some testers on this would be great. |
I will give it a shot this evening. |
Hello @UserNugget, I attempted to test your branch with the latest Velocity build and your PacketEvents branch, but encountered an issue. Specifically, I'm receiving a Is there a dependency I might be missing (I couldn't find any listed) or does this need to be tested on a Linux-based operating system instead? Test Setup
Console ScreenshotKind regards, |
@Bram1903, you should use LimboAPI build from LimboAPI PR as it have some changes required for this PR to work. |
Ahh, now it makes sense. Thanks for your quick reply. I just went offline for today, but will give this another look tomorrow morning! |
I've tried to rethink how this PR might be used in the future, and looks like there are still some issues:
So looks like this PR still require some changes. |
It would be good if they can be made soon so it's in the next release, so we don't need to use old build 😅 |
622c40d
to
cef46db
Compare
this PR can be closed, it's not needed anymore. LimboAPI works on it's own with save-uncompressed-packets: true
compatibility-mode: true |
This pull request implements support for LimboAPI and FastMOTD.
Fixes Elytrium/LimboAPI#146
Fixes #873