Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LimboAPI and FastMOTD support for Velocity #853

Closed

Conversation

UserNugget
Copy link
Contributor

@UserNugget UserNugget commented Jun 27, 2024

This pull request implements support for LimboAPI and FastMOTD.

Fixes Elytrium/LimboAPI#146
Fixes #873

@retrooper
Copy link
Owner

Does this actually work?

@UserNugget
Copy link
Contributor Author

Does this actually work?

Yep, but require a bit cleanup.

@UserNugget UserNugget force-pushed the limboapi-and-fastmotd-support branch from 4d5ca11 to 6d0b7f8 Compare July 10, 2024 01:39
@UserNugget UserNugget marked this pull request as ready for review July 10, 2024 01:47
@retrooper
Copy link
Owner

I'll happily add to the current progress, but getting some testers on this would be great.

@Bram1903
Copy link
Contributor

I will give it a shot this evening.

@Bram1903
Copy link
Contributor

Bram1903 commented Jul 10, 2024

Hello @UserNugget,

I attempted to test your branch with the latest Velocity build and your PacketEvents branch, but encountered an issue. Specifically, I'm receiving a read timed out error in my console and am unable to join the server. However, when I remove the LimboAPI plugin, everything functions as expected.

Is there a dependency I might be missing (I couldn't find any listed) or does this need to be tested on a Linux-based operating system instead?

Test Setup

  • Proxy: Velocity 3.3.0-SNAPSHOT (git-9d25d309-b400) with PacketEvents (your branch, compiled) and LimboAPI
  • Backend: Paper 1.21 (master@62ed302) with ViaVersion and ViaBackwards (5.0.1)
  • Client: 1.20.6

Console Screenshot

image

Kind regards,
Bram

@UserNugget
Copy link
Contributor Author

@Bram1903, you should use LimboAPI build from LimboAPI PR as it have some changes required for this PR to work.

@Bram1903
Copy link
Contributor

@Bram1903, you should use LimboAPI build from LimboAPI PR as it have some changes required for this PR to work.

Ahh, now it makes sense. Thanks for your quick reply. I just went offline for today, but will give this another look tomorrow morning!

@UserNugget
Copy link
Contributor Author

I've tried to rethink how this PR might be used in the future, and looks like there are still some issues:

  1. While FastPrepareAPI is used, only one PacketEvents instance will work properly
  2. While FastPrepareAPI is used, all packets that was send directly via PacketEvents will be ignored

So looks like this PR still require some changes.

@UserNugget UserNugget marked this pull request as draft July 10, 2024 20:38
@bobhenl
Copy link

bobhenl commented Aug 1, 2024

It would be good if they can be made soon so it's in the next release, so we don't need to use old build 😅

@rafi67000
Copy link
Contributor

this PR can be closed, it's not needed anymore. LimboAPI works on it's own with

     save-uncompressed-packets: true
     compatibility-mode: true

@retrooper retrooper closed this Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't access Velocity server due to LimboAPI and PacketEvents 2.4.0 PacketEvents incompability
5 participants