Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synchronize packet encoding #995

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Synchronize packet encoding #995

merged 1 commit into from
Sep 20, 2024
+10 −4

Commits on Sep 17, 2024

  1. Synchronize packet encoding 

    Resolves concurrency issues which may happen when sending the same packet wrapper to different players, concurrently

This is not a perfect solution, but the alternative would be refactoring the packetwrapper to be based on buffers passed during encoding as parameters, which would be too much effort and would require breaking changes
    @booky10
    booky10 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    a3b4cc2 View commit details
    Browse the repository at this point in the history