PPJG-2914 Remove last callback #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have to remove the previous callback if we set new items, since the callback could break the logic with the predictive animations(namely supportsPredictiveItemAnimations) which are calculated via a few onLayout callbacks
… redundant volatile annotation
Manwtein
requested review from
aleksei-tvorogov,
ilya-rb,
funriser and
octaviande
rxdiffadapter/src/main/java/com/revolut/rxdiffadapter/RxDiffAdapter.kt
Outdated
Show resolved
Hide resolved
| @@ -141,9 +143,18 @@ open class RxDiffAdapter @Deprecated("Replace with constructor without delegates | |||
| diffResult.dispatchUpdatesTo(this) | |||
| } | |||
|
|
|||
| val lastCallback = lastDispatchDiffCallback | |||
| if (lastCallback != null) { | |||
| rv.removeCallbacks(lastCallback) | |||
There was a problem hiding this comment.
Cancelling current task may postpone dispatching items to recycler(if updates happens frequently).
Proposal here:
- let's schedule task for dispatching new state(if it's required)
- make that runnable mutable and update it's state here
There was a problem hiding this comment.
Will do in a separate ticket and dm you with the reference
# Conflicts: # rxdiffadapter/src/main/java/com/revolut/rxdiffadapter/RxDiffAdapter.kt
funriser
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have to remove the previous callback if we set new items, since the callback could break the logic with the predictive animations(see supportsPredictiveItemAnimations) which are calculated via a few onLayout callback.
Dm me in slack if you need to see the reproduction