Reload from network when LazyReload was used before #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yatsinar
reviewed
Jan 3, 2024
artyomychsvc
force-pushed
the
dod_reload_after_lazy_load
branch
from
905c2a6
to
b35192a
Compare
yatsinar
requested changes
Jan 4, 2024
dod/src/main/java/com/revolut/rxdata/dod/DataObservableDelegate.kt
Outdated
Show resolved
Hide resolved
yatsinar
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the LoadingStrategy.LazyReload we can get permanent cache unintentionally.
Case:
call dod observe with the LoadingStrategy.LazyReload
and then call only dod observe with the LoadingStrategy.Auto
memory and storage cache will never be updated until the storage clean up